Skip to content

pre-push git hooks should avoid push remote when test tidy --bless failed #104718

Closed
@chenyukang

Description

@chenyukang

I met this issue several times, after I pushed code to remote PR, the CI failed because test tidy --bless failed.
https://github.com/rust-lang/rust/actions/runs/3524341026/jobs/5909613972

I have an investigation, we have a pre-push git hook setup, but seems we do not exit when test tidy --bless changed code format, and push will also successfully, then the CI will fail for this issue.

$COMMAND

I think we should keep consistent here, if there are code format issues, git push will fail until it's fixed.

A inconvenience with this is some developers may want to push frequently with temporary changes.

@jyn514

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions