Using by-value self with an immediate, implicity-copyable struct should pass a copy as the self param.

[luqmana]

This is from a code sample sent to the mailing list: https://mail.mozilla.org/pipermail/rust-dev/2013-November/006924.html

struct Value {
    n: int
}

impl Value {
    fn squared(mut self) -> Value {
        self.n *= self.n;
        self
    }
}

fn main() {
    let x = Value { n: 3 };
    let y = x.squared();
    println!("{} {}", x.n, y.n);
}

Prints out:

-> % rustc foo.rs && ./foo
9 9

The call to squared should be receiving a copy of x as the self param. This bug is only exhibited in the case of implicity copyable struct. If you add something like ~int to Value the compiler will rightly complain that x has been moved.

Also, if you add another field (like m: int) making Value an immediate no longer, we see the right behaviour:

-> % rustc foo.rs && ./foo
3 9

[huonw]

Presumably this would be fixed if we handled self as a normal argument, rather than passing it in the environment pointer (which means "by-val" self is particularly strange)?

[alexcrichton]

This seems very bad, nominating.

[thestinger]

@huonw: Yes, lets please fix this issue once and for all rather than working around the symptoms. We shouldn't be passing self as a environment pointer - it's just wrong.

[pnkfelix]

Accepted for 1.0, P-backcompat-lang

[adrientetar]

This should be closed now. (@luqmana)

[eddyb]

I put "Fixes #7411, #10615." in the commit message, but for some reason only the first one was closed.

[adrientetar]

Well, the GitHub parser doesn't take stacked declarations:
https://help.github.com/articles/closing-issues-via-commit-messages

[alexcrichton]

Thanks @eddyb!