-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ICE: failed while formatting fluent string
with debug assertions
#106755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Backtrace
|
@rustbot claim |
After doing some more investigation, this also happens on a crate with only extern crate blah; ...and the empty crate: // nothing and like the original error, |
There are a bunch of these triggering in various lints it seems, so I wonder if the assert might actually not be thaaat justified? |
#106427 changed that when a message is not in the primary bundle and debug_assertions are on, it ices. So, for example, if you are using a half translated French bundle with messages missing, and have debug_assertions on, you'll probably ice a lot. I agree that that in hindsight might have been a bad idea, and we should back that out ...however we don't actually have any other bundles, so I have no idea how this can trigger. I did some more debugging today, and it looks like the primary bundle never has any messages, so it should only trigger if the message requires formatting. I have no idea why that is or why it only happens if you have a rustc built with debug_assertions, rather than during tests for example. The only thing I can come up with is that between invoking rustc and running tests the bundle is created differently. |
Restore behavior when primary bundle is missing Fixes rust-lang#106755 by restoring some of the behavior prior to rust-lang#106427 Still, I have no idea how this debug assertion can even hit while using `en-US` as primary bundle. r? `@davidtwco`
Restore behavior when primary bundle is missing Fixes rust-lang#106755 by restoring some of the behavior prior to rust-lang#106427 Still, I have no idea how this debug assertion can even hit while using `en-US` as primary bundle. r? ``@davidtwco``
Code
rustc tests/ui/coherence/coherence-conflicting-negative-trait-impl.rs -Ztranslate-lang=en_US
The text was updated successfully, but these errors were encountered: