Skip to content

android tests pass misleadingly when a device is not available #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Dec 15, 2013 · 1 comment
Closed

android tests pass misleadingly when a device is not available #10975

brson opened this issue Dec 15, 2013 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android

Comments

@brson
Copy link
Contributor

brson commented Dec 15, 2013

stdtest etc, are not run (saying 'skipped') and compiletest makes all tests just pass. Tests should fail if they are not run correctly.
@brson brson mentioned this issue Dec 15, 2013
Merged
bors added a commit that referenced this issue Dec 19, 2013
@bors
auto merge of #10977 : brson/rust/androidtest, r=brson
b760ed6 
#10975

For a while I thought the android test bot was succeeding but it wasn't really testing anything at all.
@flaper87
Copy link
Contributor

Triage. I believe this was closed by the commit referencing it. Feel free to re-open otherwise

flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10975 - hehaoqian:fix_self_named_module_files…
f396004 
…, r=Centri3,xFrednet

Fix false positive of [self_named_module_files] and [mod_module_files]

changelog: [self_named_module_files] [mod_module_files]: No longer lints dependencies located in subdirectory of workspace

fixes rust-lang#8887

---

First time contributor here, just read contribution guide today.

I have several questions:

1. ~Is it the correct way to use environment variable `CARGO_HOME` to get the location of cargo home directory?~
(Edit: Code no longer uses CARGO_HOME)
2. How to setup test for this PR? This involves multiple files and `CARGO_HOME` setup. ~Not sure how to do this.~
~Edit: Working on tests right now~ A workspace_test has been added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flaper87 @brson