Skip to content

Rename pkgid/PkgId/pkg_id to crateid/CrateId/crate_id everywhere #11048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emberian opened this issue Dec 18, 2013 · 7 comments
Closed

Rename pkgid/PkgId/pkg_id to crateid/CrateId/crate_id everywhere #11048

emberian opened this issue Dec 18, 2013 · 7 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@emberian
Copy link
Member

#11041 changed the public API, but all of the inners still refer to it as a PkgId. They should be updated too.

@luisbg
Copy link
Contributor

luisbg commented Dec 22, 2013

I can do that :)

@luisbg
Copy link
Contributor

luisbg commented Dec 28, 2013

https://github.com/luisbg/rust/commits/master

Work partly done, check out the two last commits. Showing you to make sure this is what you wanted.

The pending renamings are all in librustpkg/, will do those in a few hours.

Cheers.

@emberian
Copy link
Member Author

Looks good! Thanks bundles.

On Sat, Dec 28, 2013 at 1:13 PM, Luis de Bethencourt <
[email protected]> wrote:

https://github.com/luisbg/rust/commits/master

Work partly done, check out the two last commits. Showing you to make sure
this is what you wanted.

The pending renamings are all in librustpkg/, will do those in a few hours.

Cheers.


Reply to this email directly or view it on GitHubhttps://github.com//issues/11048#issuecomment-31301576
.

@luisbg
Copy link
Contributor

luisbg commented Dec 29, 2013

Your comments have been fixed and the commits rebased :)

bors added a commit that referenced this issue Dec 30, 2013
@fhahn
Copy link
Contributor

fhahn commented Jan 29, 2014

I think this issue could be closed, the corresponding pull request got merged already and I couldn't find PkgId or pkgid in the source code.

@luisbg
Copy link
Contributor

luisbg commented Jan 29, 2014

Yes, it mas merged already.

@cmr, can you close it?

@alexcrichton
Copy link
Member

hurray!

flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

4 participants