Skip to content

x check checks rust-analyzer by default #112287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Noratrieb opened this issue Jun 4, 2023 · 3 comments · Fixed by #112291
Closed

x check checks rust-analyzer by default #112287

Noratrieb opened this issue Jun 4, 2023 · 3 comments · Fixed by #112291
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Noratrieb
Copy link
Member

Noratrieb commented Jun 4, 2023

Sometimes when changing compiler internals, I run x check to make sure I didn't break tools and codegen backends. This also checks rust-analyzer by default, which is not very useful, I cannot break that.

If we want to keep that, it would at least be useful to put it last so I can Ctrl-C out of it. Currently, rustfmt is checked after rust-analyzer.

@Noratrieb Noratrieb added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 4, 2023
@jyn514
Copy link
Member

jyn514 commented Jun 4, 2023

mentoring instructions: switch the order of these two lines:

check::RustAnalyzer,
check::Rustfmt,

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Jun 4, 2023
@jyn514
Copy link
Member

jyn514 commented Jun 4, 2023

@Nilstrieb points out that Cargo also isn't checked by default, so for consistency it would be nice for RustAnalyzer not to be either:

const DEFAULT: bool = true;

@sigaloid
Copy link
Contributor

sigaloid commented Jun 4, 2023

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants