Skip to content

Turn style lints to warn by default #11432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 10, 2014 · 3 comments · Fixed by #12290
Closed

Turn style lints to warn by default #11432

brson opened this issue Jan 10, 2014 · 3 comments · Fixed by #12290
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jan 10, 2014

Our stylistic lints are set to allow currently, which makes them very ineffective at promoting a consistent style across the Rust ecosystem. We should turn them on and force users to opt out of the community style.
@TisButMe TisButMe mentioned this issue Jan 10, 2014
Closed
@huonw huonw mentioned this issue Jan 19, 2014
Closed
bors added a commit that referenced this issue Jan 21, 2014
@bors
auto merge of #11663 : huonw/rust/paren-lint, r=cmr
43cffe9 
The parens in `if (true) {}` are not necessary, so we'll warn about them.

cc #3070 and #11432
@lambda-fairy
Copy link
Contributor

Looks like #11457 has fixed the issue. Should we close this?

@huonw
Copy link
Member

huonw commented Feb 1, 2014

#11457 hasn't landed yet.

@mrshu mrshu mentioned this issue Feb 15, 2014
Merged
@bors bors closed this as completed in 37903cb Feb 21, 2014
@mrshu
Copy link
Contributor

mrshu commented Feb 22, 2014

I was trying to set NonUppercaseStatics to warn and fix errors that might occur but I found out that many things depend on each other, like io/mod or io/process. What do you think should the right approach be? Just putting #[allow] there?

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 3, 2025
@samueltardieu
Validate paths in disallowed_* configurations (rust-lang#14397)
e975563 
This PR resolves rust-lang#11432 by checking that paths resolve in `disallowed_*`
configurations.

It also does some lightweight validation of definition kinds. For
example, only paths that resolve to `DefKind::Macro` definitions are
allowed in `disallowed_macro` configurations.

~The PR is currently two commits. The first is rust-lang#14376 (cc: @Jarcho),
which I submitted just a few days ago. The second commit is everything
else.~

Side note: For me, the most difficult part of this PR was getting the
spans of the individual `DisallowedPath` configurations. There is some
discussion at toml-rs/toml#840, if
interested.

changelog:  validate paths in `disallowed_*` configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed NonCamelCaseTypes lint to warn by default mrshu/rust
4 participants
@brson @mrshu @huonw @lambda-fairy