Skip to content

bootstrap: fingerprinting is broken somehow #117983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthiaskrgr opened this issue Nov 16, 2023 · 2 comments · Fixed by #117850
Closed

bootstrap: fingerprinting is broken somehow #117983

matthiaskrgr opened this issue Nov 16, 2023 · 2 comments · Fixed by #117850
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

I noticed that 2 subsequent x.py check runs would recheck a bunch of tools even with no code change in between :/

repro:
inside git repo, run

RUSTFLAGS="" RUSTC_WRAPPER=""  ./x.py check
RUSTFLAGS="" RUSTC_WRAPPER=""  ./x.py check

the second run will not finish immediately but recheck some stuff for some reason.
@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Nov 16, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 16, 2023
@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 16, 2023
@matthiaskrgr
Copy link
Member Author

Since we just updated bootstrap, this might as well be a cargo bug of some sort.

@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 16, 2023
@onur-ozkan onur-ozkan self-assigned this Nov 16, 2023
@onur-ozkan onur-ozkan mentioned this issue Nov 16, 2023
Merged
@onur-ozkan
Copy link
Member

#117850 fixes this.

@bors bors closed this as completed in 3644594 Nov 17, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 17, 2023
@rust-timer
Unrolled build for rust-lang#117850
306d464 
Rollup merge of rust-lang#117850 - onur-ozkan:fix-116538, r=Mark-Simulacrum

bootstrap: simplify setting unstable-options for tools

Previously, we unconditionally(instead of `if path == "src/tools/clippy" || ..`) set this (to prevent recompiling tools between `x check $tool` and '` check $another_tool` executions) specifically for tools in the `x check` step. This PR relocates that logic to `fn prepare_tool_cargo`, making it step-agnostic.

Fixes rust-lang#116538
Fixes rust-lang#117983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bootstrap: simplify setting unstable-options for tools onur-ozkan/rust
3 participants
@matthiaskrgr @onur-ozkan @rustbot