Skip to content

std::comm::select! needs to be an exported macro #12044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Feb 5, 2014 · 0 comments
Closed

std::comm::select! needs to be an exported macro #12044

alexcrichton opened this issue Feb 5, 2014 · 0 comments
Labels
A-concurrency Area: Concurrency A-syntaxext Area: Syntax extensions

Comments

@alexcrichton
Copy link
Member

Right now the macro isn't quite ready for use, but it's also the main way that I envision selection over channels working.

The implementation needs to be polished and made rock-solid before exporting this macro.
@alexcrichton alexcrichton mentioned this issue Feb 5, 2014
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 24, 2014
@alexcrichton
std: Export the select! macro
69c5e6f 
Mark it as #[experimental] for now. In theory this attribute will be read in the
future. I believe that the implementation is solid enough for general use,
although I would not be surprised if there were bugs in it still. I think that
it's at the point now where public usage of it will start to uncover hopefully
the last few remaining bugs.

Closes rust-lang#12044
@alexcrichton alexcrichton mentioned this issue Feb 27, 2014
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12044 - tedinski:fix_rustc_workspace, r=jonas…
71d49d3 
…-schievink

fix: index the correct CargoWorkspace with rustc_private

I believe this fixes rust-lang#12043, but I'm not sufficiently setup/familiar with working on rust-analyzer to test it locally. :/

This section of code is iterating on `rustc_workspace.packages()` but then indexes `cargo[pkg]`, which is likely the source of the bug.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 25, 2024
@bors
Auto merge of rust-lang#12074 - ARandomDev99:12044-include-comments-w…
a9fa2f5 
…hile-checking-duplicate-code, r=Jarcho

Make `HirEqInterExpr::eq_block` take comments into account while checking if two blocks are equal

This PR:
- now makes `HirEqInterExpr::eq_block` take comments into account. Identical code with varying comments will no longer be considered equal.
- makes necessary adjustments to UI tests.

Closes rust-lang#12044

**Lintcheck Changes**
- `match_same_arms` 53 => 52
- `if_same_then_else` 3 => 0

changelog: [`if_same_then_else`]: Blocks with different comments will no longer trigger this lint.
changelog: [`match_same_arms`]: Arms with different comments will no longer trigger this lint.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Concurrency A-syntaxext Area: Syntax extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std: Export the select! macro alexcrichton/rust
2 participants
@alexcrichton @huonw