Skip to content

--test-shard A.B is just broken #12540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
killerswan opened this issue Feb 25, 2014 · 4 comments
Closed

--test-shard A.B is just broken #12540

killerswan opened this issue Feb 25, 2014 · 4 comments

Comments

@killerswan
Copy link
Contributor

It seems to skip a bunch of tests and the last set is empty...

$ cat src/rustx/demo2.rs 
extern crate extra;

use std::io;

#[main]
fn say_hi () {
   io::println("Hello!!");
}

#[test]
fn testA () {
   assert! (2 + 2 == 4);
}

#[test]
fn testB () {
   assert! (2 + 2 == 4);
}

#[test]
fn testC () {
   assert! (2 + 2 == 4);
}

#[test]
fn testD () {
   assert! (2 + 2 == 4);
}

#[test]
fn testE () {
   assert! (2 + 2 == 4);
}

#[test]
fn testF () {
   assert! (2 + 2 == 4);
}

#[test]
fn testG () {
   assert! (2 + 2 == 4);
}

$ 
$ rustc --test src/rustx/demo2.rs 
...
$ ./demo2 --test-shard 1.3

running 2 tests
test testB ... ok
test testE ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured

rustx $ ./demo2 --test-shard 2.3

running 2 tests
test testC ... ok
test testF ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured

rustx $ ./demo2 --test-shard 3.3

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured
@huonw
Copy link
Member

huonw commented Feb 25, 2014

Does it start at 0.3?

@killerswan
Copy link
Contributor Author

Indeed it does! Thanks!

@pnkfelix
Copy link
Member

So is this just a documentation issue?

@brson
Copy link
Contributor

brson commented Feb 26, 2014

I think I'd like to remove this feature. This was implemented as an attempt to improve our cycle time, but we never deployed it to the bots.

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 4, 2024
Remove `unwrap` from `match_trait_method`

Unused_IO_amount relies on `match_trait_method` in order to match trait methods that exist in Tokio traits as the corresponding symbols don't exist.

With this commit we remove the unwrap that caused rust-lang#12366.
Note: author (`@m-rph)` and `@GuillaumeGomez` couldn't replicate rust-lang#12366.

changelog:none

r? `@blyxyas`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants