Skip to content

Delete libextra::unicode #12576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pzol opened this issue Feb 26, 2014 · 5 comments · Fixed by #12896
Closed

Delete libextra::unicode #12576

pzol opened this issue Feb 26, 2014 · 5 comments · Fixed by #12896
Labels
A-Unicode Area: Unicode E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@pzol
Copy link
Contributor

pzol commented Feb 26, 2014

The current code contains a binding to libicu with only is_upper and is_lower implemented, which are already implemented in libstd

/cc @cmr

@pzol pzol self-assigned this Feb 26, 2014
@kud1ing
Copy link

kud1ing commented Feb 27, 2014

I think it has never been used fully, because noone wanted the additional, heavy dependency on libicu for all Rust code. The story might be different, when this stuff got split off to something like a "libunicode".

@pzol
Copy link
Contributor Author

pzol commented Feb 27, 2014

And what should go into libunicode? All the unicode tables from
std::unicode + multibyte handling?

On Thu, Feb 27, 2014 at 8:18 AM, kud1ing [email protected] wrote:

I think it has never been used fully, because noone wanted that
additional, heavy dependency.
The story might be different, with a split to something like libunicode.


Reply to this email directly or view it on GitHubhttps://github.com//issues/12576#issuecomment-36216887
.

Piotr Zolnierek

@brson
Copy link
Contributor

brson commented Feb 28, 2014

The existing module can go, but we do need to do something with libicu bindings. Since ICU is so big we might want to give it its own crate, then put our own unicode APIs into libunicode.

@pzol
Copy link
Contributor Author

pzol commented Feb 28, 2014

What would you envision for libunicode?

I'd rather name it libi18n and place there all stuff concerning localization and internationalisation. It could start as you say as a binding to libicu, but with a much more friendly api.

The unicode tables for case folding, grapheme clustering should imo go into std::unicode.

So I would suggest to place unicode in libstd and internationalisation in libi18n or another similar name suggesting it's purpose.

Piotr

On 28 lut 2014, at 03:58, Brian Anderson [email protected] wrote:

The existing module can go, but we do need to do something with libicu bindings. Since ICU is so big we might want to give it its own crate, then put our own unicode APIs into libunicode.


Reply to this email directly or view it on GitHub.

@brson
Copy link
Contributor

brson commented Mar 1, 2014

@pzol I'm afraid I don't know enough about internationalization and localization to know what the right thing to do is, but I'm very keen to find out. Anything non-obtrusive must be better than what we are doing right now.

bors added a commit that referenced this issue Mar 15, 2014
This commit shreds all remnants of libextra from the compiler and standard
distribution. Two modules, c_vec/tempfile, were moved into libstd after some
cleanup, and the other modules were moved to separate crates as seen fit.

Closes #8784
Closes #12413
Closes #12576
@pzol pzol removed their assignment Jun 16, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
…arm, r=Veykril

feat: add fold range for multi line match arm list

fix: rust-lang#11893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Unicode Area: Unicode E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants