-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Intra-doc link should rule out hidden items when resolving ambiguous link #130233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
C-bug
Category: This is a bug.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
Sending a fix. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 12, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 12, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 12, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 14, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 14, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 2, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 8, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 8, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 10, 2024
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Oct 14, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Oct 16, 2024
…er-out-2, r=notriddle Delay ambiguous intra-doc link resolution after `Cache` has been populated Fixes rust-lang#130233. I was getting nowhere with rust-lang#130278. I took a wrong turn at some point and ended making way too many changes so instead I started again back from 0 and this time it worked out as expected. r? `@notriddle`
Urgau
added a commit
to Urgau/rust
that referenced
this issue
Oct 16, 2024
…er-out-2, r=notriddle Delay ambiguous intra-doc link resolution after `Cache` has been populated Fixes rust-lang#130233. I was getting nowhere with rust-lang#130278. I took a wrong turn at some point and ended making way too many changes so instead I started again back from 0 and this time it worked out as expected. r? ``@notriddle``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Oct 16, 2024
Rollup merge of rust-lang#131691 - GuillaumeGomez:intra-doc-link-filter-out-2, r=notriddle Delay ambiguous intra-doc link resolution after `Cache` has been populated Fixes rust-lang#130233. I was getting nowhere with rust-lang#130278. I took a wrong turn at some point and ended making way too many changes so instead I started again back from 0 and this time it worked out as expected. r? ```@notriddle```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
C-bug
Category: This is a bug.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
I expected to see this happen: No broken_intra_doc_links warning.
[`Thing`]
works and means the same thing as[`struct@Thing`]
, because[`Thing()`]
has been ruled out for being hidden. Explicitly writing[`Thing()`]
produces a broken link. Only when documented with--document-hidden-items
is there an ambiguity.Instead, this happened:
[`Thing`]
and[`Thing()`]
each produce broken link.Meta
rustc --version --verbose
:The text was updated successfully, but these errors were encountered: