Skip to content

rustdoc no longer showing rust logo #13148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 26, 2014 · 1 comment
Closed

rustdoc no longer showing rust logo #13148

brson opened this issue Mar 26, 2014 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Mar 26, 2014

http://static.rust-lang.org/doc/master/std/index.html

Probably broken by 6f6b099, which changed the html template.
@huonw
Copy link
Member

huonw commented Mar 26, 2014

It looks like it's the lines like

{favicon, select, none{} other{<link rel=\"shortcut icon\" href=\"#\" />}}

being changed into

{favicon, select, none{} other{<link rel="shortcut icon" href="\#" />}}

Specifically, the addition of the \ in front of the # is bogus, it should be referring back to the value of favicon, which is done with a plain #. (I'm away from a computer with Rust to be able make & test this change myself.)

(Similarly for the {logo, select, ... one.)

@huonw huonw added the E-easy label Mar 26, 2014
@brson brson closed this as completed in 0063504 Mar 28, 2014
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Sep 6, 2022
@bors
Auto merge of rust-lang#13151 - ChayimFriedman2:replace-turbofish-oth…
e0e18cc 
…er-type, r=Veykril

Use correct type in "Replace turbofish with type"

And support `?` and `.await` expressions.

Fixes rust-lang#13148.

The assist can still show up even if the turbofish's type is not used at all, e.g.:
```rust
fn foo<T>() {}
let v = foo::<i32>();
```
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 25, 2024
@bors
Auto merge of rust-lang#13148 - xFrednet:lintcheck-link-correction-ag…
bd1224d 
…ain, r=Alexendoo

Lintcheck: Support underscores replacement in URL crate names

The generated URLs use `{krate}` for the crate name. This works well for the first part of the docs.rs domain, but the second part is actually the root module, which requires a replacement of all dashes with underscores. This PR adds `{krate_}` for the root module name.

Diff:

```diff
 Removed `clippy::needless_borrows_for_generic_args` in `rustls-pemfile` at
-https://docs.rs/rustls-pemfile/2.1.2/src/rustls-pemfile/pemfile.rs.html#194
+https://docs.rs/rustls-pemfile/2.1.2/src/rustls_pemfile/pemfile.rs.html#194
```

> Example before: https://github.com/xFrednet/rust-clippy/actions/runs/10054236377?pr=4
> Example after: https://github.com/xFrednet/rust-clippy/actions/runs/10054878594?pr=4

---

changelog: none

r? `@Alexendoo`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @huonw