Skip to content

Support ConstArgKind::Paths for const struct/variant constructors #132985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
camelid opened this issue Nov 13, 2024 · 0 comments
Open

Support ConstArgKind::Paths for const struct/variant constructors #132985

camelid opened this issue Nov 13, 2024 · 0 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. F-min_generic_const_args `#![feature(min_generic_const_args)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Nov 13, 2024

Requires encoding const ctors in MIR metadata (not currently done for some reason). May affect perf. cc #131081.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 13, 2024
@camelid camelid mentioned this issue Nov 13, 2024
Open
15 tasks
@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-min_generic_const_args `#![feature(min_generic_const_args)]` and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 13, 2024
@camelid camelid mentioned this issue Dec 29, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 29, 2024
@bors
Auto merge of rust-lang#134873 - camelid:const-ctor-mir, r=<try>
e10a2b0 
Encode MIR for const ctors in metadata

Fixes rust-lang#132985.

This is needed for them to be usable under `min_generic_const_args`.
They are not currently encoded for some reason.

r? `@BoxyUwU`
@cyrgani cyrgani mentioned this issue Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. F-min_generic_const_args `#![feature(min_generic_const_args)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode MIR for const ctors in metadata and allow eval for them camelid/rust
3 participants
@camelid @jieyouxu @rustbot