Skip to content

Cleanup "no panic support" tests #135923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Jan 23, 2025 · 3 comments · Fixed by #136476
Closed

Cleanup "no panic support" tests #135923

jieyouxu opened this issue Jan 23, 2025 · 3 comments · Fixed by #136476
Assignees
@jieyouxu
Labels
A-panic Area: Panicking machinery A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jan 23, 2025 •
edited by rustbot
Loading

There are a bunch of tests that say ignore-wasm or ignore-emscripten or ignore-$platform with a comment "no panic support" or "no panic". It would be good to audit them and see if one or more of the following capability-based conditional test execution directives can be used instead:

  • //@ needs-unwind
  • //@ needs-threads
  • //@ needs-subprocess1

If those are not sufficient, it would be good to improve the ignore reason anyway.

Footnotes

  1. I'm still working on implementing this directive over at compiletest: add a needs-subprocess directive #128295. ↩
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 23, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 23, 2025
@jieyouxu jieyouxu added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 23, 2025
@jieyouxu
Copy link
Member Author

Tagging as E-medium because this might involve running multiple try-jobs against certain CI jobs.

@jieyouxu jieyouxu added the A-panic Area: Panicking machinery label Jan 23, 2025
@jieyouxu jieyouxu mentioned this issue Jan 24, 2025
Merged
@yegeunyang

This comment has been minimized.

Sign in to view
@yegeunyang

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu self-assigned this Jan 31, 2025
@jieyouxu jieyouxu mentioned this issue Feb 3, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 3, 2025
@bors
Auto merge of rust-lang#136476 - jieyouxu:panic-panic-panic, r=<try>
ac83dfa 
Remove redundant `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

When `//@ needs-{unwind,subprocess}` are the suitable capability guards.

Resolves rust-lang#135923.

r? `@ghost`

try-job: test-various
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 3, 2025
@bors
Auto merge of rust-lang#136476 - jieyouxu:panic-panic-panic, r=<try>
6457c68 
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

In favor of capability-based guards `//@ needs-{unwind,subprocess}`.

Resolves rust-lang#135923.

r? `@ghost`

try-job: test-various
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 3, 2025
@matthiaskrgr
Rollup merge of rust-lang#136476 - jieyouxu:panic-panic-panic, r=lcnr
70439f0 
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

In favor of capability-based guards `//@ needs-{unwind,subprocess}`.

Resolves rust-lang#135923.

r? `@ghost`

try-job: test-various
@bors bors closed this as completed in f180013 Feb 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 4, 2025
@rust-timer
Unrolled build for rust-lang#136476
5407c44 
Rollup merge of rust-lang#136476 - jieyouxu:panic-panic-panic, r=lcnr

Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

In favor of capability-based guards `//@ needs-{unwind,subprocess}`.

Resolves rust-lang#135923.

r? ``@ghost``

try-job: test-various
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-panic Area: Panicking machinery A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove generic //@ ignore-{wasm,wasm32,emscripten} in tests jieyouxu/rust
3 participants
@jieyouxu @yegeunyang @rustbot