yet-to-be-merged libregex is not testing dynamic regexps #13740
Comments
BurntSushi
added a commit
to BurntSushi/rust
that referenced
this issue
Apr 25, 2014
Before, tests for dynamic regexes ran during stage1 and tests for native regexes ran during stage2. But the buildbots don't test stage1, so now both dynamic and native tests are run during stage2. Closes rust-lang#13740.
bors
added a commit
that referenced
this issue
Apr 26, 2014
…chton Before, tests for dynamic regexes ran during stage1 and tests for native regexes ran during stage2. But the buildbots don't test stage1, so now both dynamic and native tests are run during stage2. Closes #13740.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 28, 2025
changelog: [`manual_ok_err`]: new lint
Detect manual implementations of `.ok()` or `.err()`, as in
```rust
let a = match func() {
Ok(v) => Some(v),
Err(_) => None,
};
let b = if let Err(v) = func() {
Some(v)
} else {
None
};
```
which can be replaced by
```rust
let a = func().ok();
let b = func().err();
```
This pattern was detected in the wild in the Rust reimplementation of
coreutils:
uutils/coreutils#6886 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I previously relied on an abuse of bootstrapping to test dynamic regexps during stage1 and native regexps during stage2, but it turns out stage1 tests aren't run by the bots. Since dynamic and native regexps use different code, it's imperative that both are tested.
I have a fix coming soon that will push dynamic and native regexp testing into stage2.
The text was updated successfully, but these errors were encountered: