-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Tracking issue for release notes of #138233: Windows: Don't link std (and run-make) against advapi32, except on win7 #138621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Does this require a relnote? |
I don't think so. The std library already wasn't depending on any functionality in advapi32, the PR just removed it from the list of available libs linked against. |
I have marked this as relnotes because it caused a regression in git2. libgit2's C code was using some functions from advapi32, but the build script failed to include it explicitly (it was relying on the implicit inclusion from the standard library). I think that's the fault of git2's script, but it caused a regression nonetheless. |
Oh interesting. I wouldn't have expected that, but good to know, and I hope it was an easy fix. In that case then maybe this is worth mentioning yeah. |
This seems to break diesel on windows: https://github.com/diesel-rs/diesel/actions/runs/14105676571/job/39512664331?pr=4540 |
This issue tracks the release notes text for #138233.
cc @smmalis37, @ChrisDenton -- original issue/PR authors and assignees for drafting text
See the forge.rust-lang.org chapter about release notes for an overview of how the release team makes use of these tracking issues.
Release notes text
This section should be edited to specify the correct category(s) for the change, with succinct description(s) of what changed. Some things worth considering:
Stabilized APIs
andConst Stabilized APIs
?Tip
Use the previous releases for inspiration on how to write the release notes text and which categories to pick.
Release blog section
If this change is notable enough for inclusion in the blog post then this section should be edited to contain a draft for the blog post. Otherwise leave it empty.
Note
If a blog post section is required the
release-blog-post
label should be added (@rustbot label +release-blog-post
) to this issue as otherwise it may be missed by the release team.The text was updated successfully, but these errors were encountered: