Skip to content

remove Region: Deref<Target = RegionKind> impl #139359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lcnr opened this issue Apr 4, 2025 · 3 comments · Fixed by #139509
Closed

remove Region: Deref<Target = RegionKind> impl #139359

lcnr opened this issue Apr 4, 2025 · 3 comments · Fixed by #139509
Assignees
@xizheyin
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented Apr 4, 2025 •
edited by rustbot
Loading

call .kind() in cases where it is currently used.

This impl is a relic of back when we still interned regions as &'tcx RegionKind and differs from Ty and ty::Const
@lcnr lcnr added E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Apr 4, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 4, 2025
@lcnr lcnr added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Apr 4, 2025
@xizheyin
Copy link
Contributor

xizheyin commented Apr 7, 2025

How difficult is it to do this? I would love to do this.

@lcnr
Copy link
Contributor Author

lcnr commented Apr 7, 2025

Some familiarity with the compiler helps, but it should be doable.

@xizheyin
Copy link
Contributor

xizheyin commented Apr 7, 2025

I can try and may need some advice if necessary.

@rustbot claim

@xizheyin xizheyin mentioned this issue Apr 8, 2025
Merged
@bors bors closed this as completed in 1cbf8b5 Apr 9, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 9, 2025
@rust-timer
Unrolled build for rust-lang#139509
9ecbcfe 
Rollup merge of rust-lang#139509 - xizheyin:issue-139359, r=lcnr

clean: remove Deref<Target=RegionKind> impl for Region and use `.kind()`

Closes rust-lang#139359

r? `@lcnr`
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xizheyin xizheyin

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean: remove Deref<Target=RegionKind> impl for Region and use .kind() xizheyin/rust
4 participants
@lcnr @jieyouxu @rustbot @xizheyin