Skip to content

Remove crates.io compiler-builtins from the library workspace #142265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tgross35 opened this issue Jun 9, 2025 · 0 comments
Open

Remove crates.io compiler-builtins from the library workspace #142265

tgross35 opened this issue Jun 9, 2025 · 0 comments
Assignees
@tgross35
Labels
A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@tgross35
Copy link
Contributor

tgross35 commented Jun 9, 2025 •
edited
Loading

After #141993 we should eliminate compiler-builtins from any crates that are depending on it via crates.io to remove the duplicate dependency so the patch isn't needed. Todo list, taken from the PR:
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 9, 2025
@tgross35 tgross35 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 9, 2025
@tgross35 tgross35 self-assigned this Jun 9, 2025
@tgross35 tgross35 mentioned this issue Jun 9, 2025
Merged
tgross35 added a commit to tgross35/rust that referenced this issue Jun 10, 2025
@tgross35
Update dependencies in library/Cargo.lock
dd7621d 
This removes the `compiler_builtins` dependency from a handful of
library dependencies, which is progress toward [1].

[1]: rust-lang#142265
@tgross35 tgross35 mentioned this issue Jun 10, 2025
Open
tgross35 added a commit to tgross35/rust that referenced this issue Jun 10, 2025
@tgross35
Update dependencies in library/Cargo.lock
096c29a 
This removes the `compiler_builtins` dependency from a handful of
library dependencies, which is progress toward [1].

[1]: rust-lang#142265
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Jun 11, 2025
@workingjubilee
Rollup merge of rust-lang#142276 - tgross35:update-library-lockfile, …
b693447 
…r=Mark-Simulacrum

Update dependencies in `library/Cargo.lock`

This removes the `compiler_builtins` dependency from a handful of library dependencies, which is progress toward [1].

[1]: rust-lang#142265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgross35 tgross35

Labels
A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgross35 @rustbot