Skip to content

Arc::make_unique ignores weak references #14521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aturon opened this issue May 29, 2014 · 0 comments
Closed

Arc::make_unique ignores weak references #14521

aturon opened this issue May 29, 2014 · 0 comments

Comments

@aturon
Copy link
Member

aturon commented May 29, 2014

The make_unique method for Arcs only ensures a unique strong reference. It needs to check the weak reference count as well.
@aturon aturon mentioned this issue May 29, 2014
Closed
bors added a commit that referenced this issue May 30, 2014
@bors
auto merge of #14522 : aturon/rust/make_unique, r=alexcrichton,alexcr…
32b6fc1 
…ichton,me

This patch makes `Arc::make_unique` examine the number of weak
references as well as strong references, which is required for safety.

It also adds a `make_unique` method to the `Rc` type for consistency.

Closes #14521.
@aturon aturon closed this as completed in 7889c95 May 30, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14521 - HKalbasi:dev, r=Veykril
937ef97 
Add bounds for fields in derive macro

Dependency of rust-lang#14470
flip1995 added a commit to flip1995/rust that referenced this issue Apr 3, 2025
@flip1995
Stop relabelling PRs with merge conflicts (rust-lang#14521)
0ca62d1 
r? @flip1995

After seeing some PRs get relabelled I think it's probably for the best
not to, a conflict doesn't mean it's no longer waiting for review after
all

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Arc::make_unique check weak refs; add make_unique to Rc aturon/rust
1 participant
@aturon