Skip to content

Implement (back) ToJson on &[T] #14619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimonSapin opened this issue Jun 3, 2014 · 1 comment
Closed

Implement (back) ToJson on &[T] #14619

SimonSapin opened this issue Jun 3, 2014 · 1 comment

Comments

@SimonSapin
Copy link
Contributor

The ToJson trait has implementations for ~[T] and Vec<T>, but not &[T]. I suppose it was accidentally removed at some point. Please bring it back. (The implementation should be identical to the other two.)
@japaric
Copy link
Member

japaric commented Jun 3, 2014

I have implemented this locally, I'll add some test and send a PR.

@bors bors closed this as completed in a413d00 Jun 3, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14619 - HKalbasi:dev3, r=Veykril
3a08713 
Fix need-mut large span in closures and a false positive

fix rust-lang#14612
flip1995 pushed a commit to flip1995/rust that referenced this issue May 15, 2025
@Manishearth
item_name_repetitions: exclude enum variants with identical path co…
fc811f7 
…mponents (rust-lang#14619)

fix rust-lang/rust-clippy#13637

As suggested in the PR above, we should not lint enum variants
containing matching path names.

changelog: [`item_name_repetitions`]: exclude enum variants with
identical path components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @japaric