-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Closed as not planned
Closed as not planned
Copy link
Labels
A-PythonArea: Python, like bootstrap/CI scripts or linters/formatters, etc.Area: Python, like bootstrap/CI scripts or linters/formatters, etc.C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Remark: we should go through
bootstrap.pyand make sure we specific explicitopen()encodings, as far as I am aware there is a reasonable desire to want to make a future change in Python 3.* whereopen()defaults to UTF-8 encoding, which could breakopen()on binary files called elsewhere in this script.
Originally posted by @jieyouxu in #152485 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-PythonArea: Python, like bootstrap/CI scripts or linters/formatters, etc.Area: Python, like bootstrap/CI scripts or linters/formatters, etc.C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)