Skip to content

Cleanup: go through bootstrap.py and make sure we specify explicit open() encodings #152510

@jieyouxu

Description

@jieyouxu

Remark: we should go through bootstrap.py and make sure we specific explicit open() encodings, as far as I am aware there is a reasonable desire to want to make a future change in Python 3.* where open() defaults to UTF-8 encoding, which could break open() on binary files called elsewhere in this script.

Originally posted by @jieyouxu in #152485 (comment)

Metadata

Metadata

Labels

A-PythonArea: Python, like bootstrap/CI scripts or linters/formatters, etc.C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions