Skip to content

Rename UDP method. #15360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbcrail opened this issue Jul 3, 2014 · 7 comments
Closed

Rename UDP method. #15360

jbcrail opened this issue Jul 3, 2014 · 7 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@jbcrail
Copy link
Contributor

jbcrail commented Jul 3, 2014

In src/libstd/io/net/udp.rs on line 168, set_broadast should be renamed to set_broadcast.
@alexcrichton
Copy link
Member

Wow. Yet another reason for me to get a spell check plugin!

@jbcrail
Copy link
Contributor Author

jbcrail commented Jul 3, 2014

I would've attached a pull request, but I wasn't sure if a deprecated attribute was needed since this involves a rename of a method.

@alexcrichton
Copy link
Member

I think it's ok to rename this method with #[deprecated]. I feel like if anyone else had used it before that this issue would have been opened earlier!

@jbcrail jbcrail mentioned this issue Jul 3, 2014
Closed
@adrientetar
Copy link
Contributor

Yet another reason for me to get a spell check plugin!

Or a mechanical keyboard if you haven't one. ;)

@omasanori
Copy link
Contributor

#15361 is merged, so is it fixed now?

@huonw huonw closed this as completed Jul 4, 2014
@huonw
Copy link
Member

huonw commented Jul 4, 2014

Yep, looks like it. (Thanks @jbcrail!)

@huonw
Copy link
Member

huonw commented Jul 5, 2014

Wow. Yet another reason for me to get a spell check plugin!

https://github.com/huonw/spellck#lint ;P

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 7, 2023
@bors
Auto merge of rust-lang#15360 - lowr:fix/mbe-transcribe-path-of-diffe…
cecbed9 
…rent-types, r=HKalbasi

Fixup path fragments upon MBE transcription

Fixes rust-lang#14367

There are roughly two types of paths: paths in expression context, where a separator `::` between an identifier and its following generic argument list is mandatory, and paths in type context, where `::` can be omitted.

Unlike rustc, we need to transform the parsed fragments back into tokens during transcription. When the matched path fragment is a type-context path and is transcribed as an expression-context path, verbatim transcription would cause a syntax error.

This PR fixes up path fragments by inserting `::` to make sure they are syntactically correct in all contexts. Note that this works because expression-context paths are a strict superset of type-context paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jbcrail @alexcrichton @omasanori @huonw @adrientetar