Skip to content

Tag types should be internally stored nominally, not structurally #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcwalton opened this issue Aug 31, 2010 · 1 comment
Closed

Tag types should be internally stored nominally, not structurally #157

pcwalton opened this issue Aug 31, 2010 · 1 comment
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-type-system Area: Type system

Comments

@pcwalton
Copy link
Contributor

Currently, tag types are stored structurally in ast.ml. Instead they should reference the actual MOD_ITEM_tag. This issue causes a number of ill effects: issue #150 stems from this (although it can be fixed before this is), as well as the problem whereby if two modules A and B both contain "type foo = tag(a(), b(), c())", the types are interchangeable.
@graydon
Copy link
Contributor

graydon commented Jan 27, 2011

WONTFIX (not required for bootstrapping; code is all different in rustc).

keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@alexcrichton
Merge pull request rust-lang#157 from dhuseby/fixing_bsd_ncpu
f9073f4 
Fixes rust-lang#156
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@Havvy
Merge pull request rust-lang#157 from notriddle/patch-1
11f33bd 
Rename C-like enum to Field-less enum
djtech-dev pushed a commit to djtech-dev/rust that referenced this issue Dec 9, 2021
@TheDan64
Merge pull request rust-lang#157 from seanyoung/sizeof
5610ee7 
Introduce size_of() on BasicTypeEnum
celinval pushed a commit to celinval/rust-dev that referenced this issue Nov 13, 2024
@qinheping
Add loop contracts and harness for slice::is_ascii (rust-lang#157)
576fbe4
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-type-system Area: Type system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @pcwalton