Skip to content

libuuid mixes up str and string #15731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sinistersnare opened this issue Jul 17, 2014 · 1 comment
Closed

libuuid mixes up str and string #15731

sinistersnare opened this issue Jul 17, 2014 · 1 comment

Comments

@sinistersnare
Copy link
Contributor

The libuuid documentation (and henceforth the source code itself) mixes up string and str in method signatures, specifically the name of the method itself.

Proposed changes:

  • fn to_simple_str(&self) -> String => fn to_simple_string(&self) -> String
  • fn to_hyphenated_str(&self) -> String => fn to_hyphenated_string(&self) -> String
  • fn to_urn_str(&self) -> String => fn to_urn_string(&self) -> String
  • fn parse_string(us: &str) -> Result<Uuid, ParseError> => fn parse_str(us: &str) -> Result<Uuid, ParseError>
@sinistersnare sinistersnare changed the title lib uuid mixes up str and string libuuid mixes up str and string Jul 17, 2014
@sinistersnare
Copy link
Contributor Author

Going to close this and open an issue / send a PR to here

lnicola pushed a commit to lnicola/rust that referenced this issue Jan 3, 2024
…e-conflicts, r=Veykril

fix: pick up new names when the name conflicts in 'introduce_named_generic'

Improve generation of names for generic parameters in `introduce_named_generics`.

fix rust-lang#15731.

### Changes

- Modified `for_generic_parameter` function in `suggest_name.rs` to handle conflicts with existing generic parameters and generate unique names accordingly.
- Update `introduce_named_generic` function and pass existing params to `for_generic_parameter`, enabling the detection and handling of name collisions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant