Block comment grammar

[mikesamuel]

http://doc.rust-lang.org/doc/rust.html#comments describes the grammar of block comments as

block_comment : "/" block_comment_body * "/" ;
block_comment_body : block_comment | non_star * | '*' non_slash ;

Since non_slash matches '*', this would mean that

/***/

is not a full block comment, because the */ at the end matches '' non_slash, and then '/' is left to match non_star.

/***/*/

is a single block comment token.

Perhaps

'*' non_slash

should be

'*'+ non_star_slash

Also, if the block_comment in block_comment_body is meant to allow nested comments, then

non_star *

should probably also use non_star_slash to give the unambiguous

block_comment : "/" block_comment_body * "/" ;
block_comment_body : block_comment | ("*" *) non_star_slash ;

[z0w0]

I think this has been fixed somewhere along the line. Can you confirm?

[jbclements]

The parser does the right thing, but I agree with the poster that the specified grammar is broken. The proposed fix doesn't quite work, but putting the '+' on the star at the end does work.

[jbclements]

fixed by #5583 , I believ.