Clean up snake case warnings in middle/trans/build.rs #16880
Comments
|
Upon further review, it appears that the issue is actually that the directive I can run through and update all of these if someone can confirm for me that my assumption is correct. |
|
Upon further-further review, I discovered this very recent commit that modified I'm going to settle down and let someone that knows what they're talking about comment on this. :) |
|
Yeah, still getting a lot of these. |
This unifies the `non_snake_case_functions` and `uppercase_variables` lints into one lint, `non_snake_case`. It also now checks for non-snake-case modules. This also extends the non-camel-case types lint to check type parameters, and merges the `non_uppercase_pattern_statics` lint into the `non_uppercase_statics` lint. Because the `uppercase_variables` lint is now part of the `non_snake_case` lint, all non-snake-case variables that start with lowercase characters (such as `fooBar`) will now trigger the `non_snake_case` lint. New code should be updated to use the new `non_snake_case` lint instead of the previous `non_snake_case_functions` and `uppercase_variables` lints. All use of the `non_uppercase_pattern_statics` should be replaced with the `non_uppercase_statics` lint. Any code that previously contained non-snake-case module or variable names should be updated to use snake case names or disable the `non_snake_case` lint. Any code with non-camel-case type parameters should be changed to use camel case or disable the `non_camel_case_types` lint. [breaking-change]
|
As I noted in the original pull request that caused this change, a snapshot would fix this. A temporary fix would be to add |
|
Ahh, I am bad at github-fu. Yes, if this is going to be fixed by a snapshot, then this bug probably isn't actionable. Do we know when the next snapshot is? |
|
@huonw is on the case! |
Use `--workspace` and `--no-fail-fast` in test explorer This PR contains: * Using `--workspace` in `cargo test` command, to running all tests even when there is a crate in the root of a workspace * Using `--no-fail-fast` to run all requested tests * Excluding bench in the test explorer * Fixing a bug in the `hack_recover_crate_name` fix rust-lang#16874
When building rustc, several warnings are generated regarding non-snake-case functions in middle/trans/build.rs.
There's a
#![allow(non_snake_case)]directive at the top, but no#![allow(non_snake_case_functions)]. Presumably we should either add that to permit the functions as they're currently named or rename the functions.Happy to work on this! Which approach should I take?
The text was updated successfully, but these errors were encountered: