Skip to content

Mobile site text size #17926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
libertyha opened this issue Oct 10, 2014 · 11 comments
Closed

Mobile site text size #17926

libertyha opened this issue Oct 10, 2014 · 11 comments

Comments

@libertyha
Copy link

Hi,

I believe there is a possible design issue on the mobile site. On the page doc.rust-lang.org/nightly/intro.html (the page that appears after clicking "show me more!" on the home screen) the text is very small for a mobile site. Zooming in and scrolling sideways and then scrolling down is possible but cumbersome. I was using an IPhone 4.

-Liberty H.A.

@jdm jdm added the A-docs label Oct 10, 2014
@Anttonii
Copy link

The website is fine when viewed on my iPhone 5s.

@nodakai
Copy link
Contributor

nodakai commented Oct 11, 2014

On my iPhone 5s:

default

@steveklabnik
Copy link
Member

Here's a screenshot from the simulator on 4: https://twitter.com/pbowden/status/537287102699147264

Wonder what's different?

@acdha
Copy link

acdha commented Nov 25, 2014

It's definitely a bit small on an iPhone 4S. That really looks like it's not picking up a viewport declaration:

2014-11-25 11 50 09

@steveklabnik
Copy link
Member

@acdha
Copy link

acdha commented Nov 25, 2014

Oh, there actually isn't a viewport declaration – adding something like this should fix that:

<meta name="viewport" content="width=device-width, initial-scale=1.0">

That's probably nicer than the usual app-style habit of preventing zooming altogether:

<meta name="viewport" content="user-scalable=no, width=device-width, initial-scale=1.0, maximum-scale=1.0">

@steveklabnik
Copy link
Member

@acdha ahhh that would make sense. it looks like we need to use a meta tag for legacy stuff: http://html5hacks.com/blog/2012/11/28/elegantly-resize-your-page-with-the-at-viewport-css-declaration/

@steveklabnik
Copy link
Member

I'm going to stop posting screenshots, as they all show that this is true 😄

@kerrizor
Copy link

Able to reproduce this on an iPhone 4 in both Safari and Chrome mobile browsers.

(Late to the party)

@iKevinY
Copy link
Contributor

iKevinY commented Jan 7, 2015

I can confirm that adding the viewport meta tag as @acdha suggested makes the documentation significantly more readable on mobile (iPhone 6 screenshots to round out the iOS device mentions):

rustdoc

Text is kind of big in landscape, but I think it would only take a bit of CSS to fix this:

landscape

Pretty much all "mobile-optimized" sites opt for the app-like viewport settings (where zooming is disabled altogether), so my two cents would be to go with the latter of @acdha's two examples.

@iKevinY
Copy link
Contributor

iKevinY commented Jan 18, 2015

I believe this issue has been addressed in #21133.

@jdm jdm closed this as completed Jan 18, 2015
lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
Implement floating point casts in const eval

fix rust-lang#17926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants