Differents type signature (address, port) for TCP and UDP connection

[rach]

Hi,

The closest ticket that I could find was #14755 but it seems closed due to inactivity.
There is maybe a reason but I found a bit odd that TCP connection is done via ( &str , u16 ) and UDP via std::io::net::ip::SocketAddr . Looking at the history it seem like TCP changed to step away from SocketAddr.

TCP:

rust/src/libstd/io/net/tcp.rs

Line 350 in 56d544f

pub fn bind(addr: &str, port: u16) -> IoResult<TcpListener> {

UDP:

rust/src/libstd/io/net/udp.rs

Line 68 in 56d544f

pub fn bind(addr: SocketAddr) -> IoResult<UdpSocket> {

Thanks.

[rach]

By the way, I'm ok to submit a PR if somebody can tell me which version should be implemented (if it's not made on purpose)

[alexcrichton]

The vague reasoning behind this was that by taking &str for the IP for a TCP socket we can handle hostnames as well as IPs. For UDP, however, there's no need to handle a hostname (b/c you're only binding a socket).

That's not a very strong argument, however, and these likely need to be redesigned to be unified.

[zonyitoo]

Another possible solution is to extend SocketAddr to something like

pub enum AddrType {
    HostNameAddress(String),
    IpAddress(IpAddr),
}

pub struct SocketAddr {
    pub addr: AddrType,
    pub port: Port,
}

just for illustration.

[barosl]

I think this issue can be closed now. Both bind() functions now accept the same arguments, and AddrType suggested by @zonyitoo was implemented using the std::io::net::ip::ToSocketAddr trait.

[steveklabnik]

Yup!