rustdoc: stability summary does not handle reexports correctly #18812
Labels
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
aturon
added
the
T-rustdoc
|
This may be specific to impl blocks in re-exported modules. |
aturon
added a commit
to aturon/rust
that referenced
this issue
Nov 10, 2014
Previously, the stability summary page attempted to associate impl blocks with the module in which they were defined, rather than the module defining the type they apply to (which is usually, but not always, the same). Unfortunately, due to the basic architecture of rustdoc, this meant that impls from re-exports were not being counted. This commit makes the stability summary work the same way that rustdoc's rendered output does: all methods are counted alongside the type they apply to, no matter where the methods are defined. In addition, for trait impl blocks only the stability of the overall block is counted; the stability of the methods within is not counted (since that stability level is part of the trait definition). Fixes rust-lang#18812
bors
added a commit
that referenced
this issue
Nov 12, 2014
Previously, the stability summary page attempted to associate impl blocks with the module in which they were defined, rather than the module defining the type they apply to (which is usually, but not always, the same). Unfortunately, due to the basic architecture of rustdoc, this meant that impls from re-exports were not being counted. This commit makes the stability summary work the same way that rustdoc's rendered output does: all methods are counted alongside the type they apply to, no matter where the methods are defined. In addition, for trait impl blocks only the stability of the overall block is counted; the stability of the methods within is not counted (since that stability level is part of the trait definition). Fixes #18812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The stability summary page does not appear to inline across reexports properly. For example,
trie_mapinstd::collectionsis currently shown as entirely experimental, but inlibcollectionshas a non-trivial percentage of unstable items.The text was updated successfully, but these errors were encountered: