Skip to content

DerefMut should be for Sized? #19493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pythonesque opened this issue Dec 3, 2014 · 5 comments · Fixed by #19520
Closed

DerefMut should be for Sized? #19493

pythonesque opened this issue Dec 3, 2014 · 5 comments · Fixed by #19520

Comments

@pythonesque
Copy link
Contributor

This currently is not the case, so you can't impl DerefMut<T> for Foo where Foo is unsized. Note that this is distinct from whether T is Sized? (it is).
@csouth3
Copy link
Contributor

csouth3 commented Dec 3, 2014

Hmm, yeah I guess at first glance it seems strange that Deref is for Sized? but DerefMut is not...and this at least looks like an easy fix to me.

@csouth3
Copy link
Contributor

csouth3 commented Dec 4, 2014

I'm not really sure who to ping on this, maybe I should just make up a pull request and see what happens?

@pythonesque
Copy link
Contributor Author

Yeah, probably :)

@sfackler
Copy link
Member

sfackler commented Dec 4, 2014

Yeah, just adding for Sized? seems fine.

@csouth3
Copy link
Contributor

csouth3 commented Dec 4, 2014

Awesome. I'll put together a pull request now then.

@csouth3 csouth3 mentioned this issue Dec 4, 2014
Merged
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 28, 2025
@Veykril
Merge pull request rust-lang#19493 from Veykril/push-tlwonkmlonqv
fabb6fd 
chore: Disable rust-cache in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DerefMut should be for Sized? csouth3/rust
3 participants
@pythonesque @sfackler @csouth3