Skip to content

Upgrade rust-installer #21117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 13, 2015 · 3 comments · Fixed by #22256
Closed

Upgrade rust-installer #21117

brson opened this issue Jan 13, 2015 · 3 comments · Fixed by #22256
Assignees
@brson
Labels
P-medium Medium priority
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Jan 13, 2015

There are a few issues of polish that I want to fix here:

  • Although the installer internally supports multiple components there is no interface for actually selecting individual components. This is important because it allows to not install docs, which are 250 MB of the 50 MB install.
  • Uninstallation can only be done through the original installer, which in many cases means the user is going to have to download the installer again. I want to put an uninstall script in the installation.

This will require some refactoring and an upgrade of the installer manifest format.
@brson
Copy link
Contributor Author

brson commented Jan 13, 2015

This is a prereq for my plan to fix the .pkg uninstall issue #20597

@brson
Copy link
Contributor Author

brson commented Jan 13, 2015

cc rust-lang/rust-installer#8

@brson
Copy link
Contributor Author

brson commented Jan 13, 2015

cc rust-lang/rust-installer#9

@brson brson self-assigned this Jan 13, 2015
@brson brson mentioned this issue Jan 14, 2015
Closed
@brson brson removed the I-nominated label Jan 15, 2015
@brson brson added this to the 1.0 milestone Jan 15, 2015
@brson brson added the P-medium Medium priority label Jan 15, 2015
@brson brson mentioned this issue Feb 13, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 15, 2015
@Manishearth
Rollup merge of rust-lang#22256 - brson:installer-next, r=alexcrichton
97503e1 
 Highlights:

* Adds an 'uninstall.sh' script to `/usr/local/lib/rustlib/uninstall.sh`, the path to which is printed during installation.
* Components can be deselected during install, like `install.sh --without=rust-docs`.
* Components can be listed with `install.sh --list-components`.
* Vastly reduces spew during install (but supporting a `--verbose` option).

Typicall install run looks like:

```
brian@brianX1:~/dev/multirust⟫ sudo ./install.sh
[sudo] password for brian:
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'cargo'
install: installing component 'rust-docs'

    Rust is ready to roll.
```

Needs to be merged right before corresponding PRs to cargo and rust-packaging.

Fixes rust-lang#21117
Fixes rust-lang#20283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
P-medium Medium priority
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Installer updates brson/rust
1 participant
@brson