Skip to content

Change unwinding line arguments from usize to u32 #24208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rprichard opened this issue Apr 8, 2015 · 4 comments
Closed

Change unwinding line arguments from usize to u32 #24208

rprichard opened this issue Apr 8, 2015 · 4 comments

Comments

@rprichard
Copy link
Contributor

The file_line arguments to std::rt::unwind::begin_unwind and std::rt::unwind::begin_unwind_fmt takes a &(&str, usize). We changed line! to u32, so we should also update these two functions to also take a u32.

I had noticed this a while ago, but had been putting off fixing them, because it didn't seem time-sensitive. However, I realized today that these functions are stable, so it's technically a breaking-change.

@rprichard
Copy link
Contributor Author

Also, given the existence of #[allow_internal_unstable], do we really intend these functions to be stable?

alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 8, 2015
Now that we have a `#[allow_internal_unstable]` attribute for macros there's no
need for these two `begin_unwind` functions to be stable. Right now the `panic!`
interface is the only one we wish to stabilize, so remove the stability markers
from these functions.

While this is a breaking change, it is highly unlikely to break any actual code.
It is recommended to use the `panic!` macro instead if it breaks explicit calls
into `std::rt`.

[breaking-change]
cc rust-lang#24208
@alexcrichton
Copy link
Member

Oh yay we definitely don't need to! I've opened #24212 on this topic.

Manishearth added a commit to Manishearth/rust that referenced this issue Apr 9, 2015
…nd, r=huonw

 Now that we have a `#[allow_internal_unstable]` attribute for macros there's no
need for these two `begin_unwind` functions to be stable. Right now the `panic!`
interface is the only one we wish to stabilize, so remove the stability markers
from these functions.

While this is a breaking change, it is highly unlikely to break any actual code.
It is recommended to use the `panic!` macro instead if it breaks explicit calls
into `std::rt`.

[breaking-change]
cc rust-lang#24208
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 9, 2015
…nd, r=huonw

 Now that we have a `#[allow_internal_unstable]` attribute for macros there's no
need for these two `begin_unwind` functions to be stable. Right now the `panic!`
interface is the only one we wish to stabilize, so remove the stability markers
from these functions.

While this is a breaking change, it is highly unlikely to break any actual code.
It is recommended to use the `panic!` macro instead if it breaks explicit calls
into `std::rt`.

[breaking-change]
cc rust-lang#24208
@steveklabnik
Copy link
Member

Given that said PR was merged, should this be closed, or not? It's purely internal now, yeah?

@rprichard
Copy link
Contributor Author

Yes, it's purely internal now, so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants