-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Change unwinding line arguments from usize to u32 #24208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also, given the existence of |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Apr 8, 2015
Now that we have a `#[allow_internal_unstable]` attribute for macros there's no need for these two `begin_unwind` functions to be stable. Right now the `panic!` interface is the only one we wish to stabilize, so remove the stability markers from these functions. While this is a breaking change, it is highly unlikely to break any actual code. It is recommended to use the `panic!` macro instead if it breaks explicit calls into `std::rt`. [breaking-change] cc rust-lang#24208
Oh yay we definitely don't need to! I've opened #24212 on this topic. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Apr 9, 2015
…nd, r=huonw Now that we have a `#[allow_internal_unstable]` attribute for macros there's no need for these two `begin_unwind` functions to be stable. Right now the `panic!` interface is the only one we wish to stabilize, so remove the stability markers from these functions. While this is a breaking change, it is highly unlikely to break any actual code. It is recommended to use the `panic!` macro instead if it breaks explicit calls into `std::rt`. [breaking-change] cc rust-lang#24208
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Apr 9, 2015
…nd, r=huonw Now that we have a `#[allow_internal_unstable]` attribute for macros there's no need for these two `begin_unwind` functions to be stable. Right now the `panic!` interface is the only one we wish to stabilize, so remove the stability markers from these functions. While this is a breaking change, it is highly unlikely to break any actual code. It is recommended to use the `panic!` macro instead if it breaks explicit calls into `std::rt`. [breaking-change] cc rust-lang#24208
Given that said PR was merged, should this be closed, or not? It's purely internal now, yeah? |
Yes, it's purely internal now, so this issue can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
file_line
arguments tostd::rt::unwind::begin_unwind
andstd::rt::unwind::begin_unwind_fmt
takes a&(&str, usize)
. We changedline!
tou32
, so we should also update these two functions to also take au32
.I had noticed this a while ago, but had been putting off fixing them, because it didn't seem time-sensitive. However, I realized today that these functions are stable, so it's technically a breaking-change.
The text was updated successfully, but these errors were encountered: