Skip to content

Lint pass to flag unneeded qualified names #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 8, 2012 · 1 comment
Closed

Lint pass to flag unneeded qualified names #2551

catamorphism opened this issue Jun 8, 2012 · 1 comment
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@catamorphism
Copy link
Contributor

I noticed that in ty, there was some code that referred to ast::m_mutbl even though ty imports syntax::ast::*, so it could just be m_mutbl. There should be a lint pass to point out these cases so as to reduce the amount of random noise in code.
@catamorphism
Copy link
Contributor Author

Still a good idea IMO; doesn't really fit into any of the milestones.

@sanxiyn sanxiyn mentioned this issue Jul 11, 2013
Closed
@bors bors closed this as completed in ad70813 Jul 12, 2013
oli-obk pushed a commit to oli-obk/rust that referenced this issue Sep 19, 2022
@bors
Auto merge of rust-lang#2551 - RalfJung:rustup, r=RalfJung
4b9463c 
rustup

Cc rust-lang#101867
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Fix flaky tests (rust-lang#2553)
43bc890 
This PR fixes a few flaky tests that started to fail in the ongoing toolchain update (rust-lang#2551)

- The object bits test itself doesn't create that many objects since an array is represented as the same allocated object. Use LinkedList instead.
- Do not rely on property number.
- Do not rely on the order that failed checks is printed.
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @adpaco-aws
Upgrade rust toolchain to nightly-2023-06-20 (rust-lang#2551)
7139063 
Change Kani's compiler and tests to adapt to changes done to the toolchain. The biggest changes were:

Implement overflow checks as part of rvalue.rs instead of intrinsics due to lowering of intrinsics to BinOp.
Add a unsupported check for handling C string literals.


Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a lint to detect unnecessarily qualified names sanxiyn/rust
1 participant
@catamorphism