Skip to content

Improve documentation for Vec::as_slice #25622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbrubeck opened this issue May 19, 2015 · 5 comments · Fixed by #25838
Closed

Improve documentation for Vec::as_slice #25622

mbrubeck opened this issue May 19, 2015 · 5 comments · Fixed by #25838

Comments

@mbrubeck
Copy link
Contributor

Vec::as_slice and Vec::as_mut_slice are both marked unstable with reason "waiting on RFC revision." But the docs for as_mut_slice say that it is deprecated.

If these methods are deprecated, they should be marked deprecated instead of unstable. And either way, a hint should be added regarding how to replace Vec::as_slice in old code.

[moved from rust-lang/rfcs#1128]
@mbrubeck
Copy link
Contributor Author

cc @bluss

@Aatch Aatch added the A-docs label May 20, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this issue May 27, 2015
@steveklabnik
Deprecate Vec::as_{mut_,}slice
e08daaf 
Slicing syntax should be used instead.

Fixes rust-lang#25622
@steveklabnik steveklabnik mentioned this issue May 27, 2015
Closed
@steveklabnik
Copy link
Member

See #25833 (comment) , this is actually correct

@mbrubeck
Copy link
Contributor Author

There are still these problems to be fixed:

  • as_mut_slice docs say it is deprecated, when it isn't.
  • as_slice docs don't point to the stable alternative &v[..].

@mbrubeck mbrubeck reopened this May 27, 2015
mbrubeck added a commit to mbrubeck/rust that referenced this issue May 27, 2015
@mbrubeck
Improve docs for Vec::as_slice and as_mut_slice
6c2b340 
Fixes rust-lang#25622.
@mbrubeck mbrubeck mentioned this issue May 27, 2015
Merged
@steveklabnik
Copy link
Member

as_mut_slice docs say it is deprecated, when it isn't.

Which are these? It shows as unstable in that patch I worked up

@steveklabnik
Copy link
Member

ahhh i see, it's in the words, not the attribute

steveklabnik added a commit to steveklabnik/rust that referenced this issue May 29, 2015
@steveklabnik
Rollup merge of rust-lang#25838 - mbrubeck:doc-edit, r=steveklabnik
0ebda55 
Fixes rust-lang#25622. r? @steveklabnik
steveklabnik added a commit to steveklabnik/rust that referenced this issue May 29, 2015
@steveklabnik
Rollup merge of rust-lang#25838 - mbrubeck:doc-edit, r=steveklabnik
d3a9dc1 
Fixes rust-lang#25622. r? @steveklabnik
bors added a commit that referenced this issue May 29, 2015
@bors
Auto merge of #25838 - mbrubeck:doc-edit, r=steveklabnik
db1c761 
Fixes #25622. r? @steveklabnik
XMPPwocky pushed a commit to XMPPwocky/rust that referenced this issue May 29, 2015
@mbrubeck @XMPPwocky
Improve docs for Vec::as_slice and as_mut_slice
04f8545 
Fixes rust-lang#25622.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mbrubeck @steveklabnik @Aatch