Skip to content

Building rustc broken for multiple targets due to lack of LINK_ entry in cfg/mk/*.mk #25802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codyps opened this issue May 26, 2015 · 4 comments · Fixed by #25799
Closed

Building rustc broken for multiple targets due to lack of LINK_ entry in cfg/mk/*.mk #25802

codyps opened this issue May 26, 2015 · 4 comments · Fixed by #25799

Comments

@codyps
Copy link
Contributor

codyps commented May 26, 2015

Appears like:

| CFG_LLVM_LINKAGE_FILE=/home/cody/obj/y/tmp/work/x86_64-poky-linux-gnueabi/rust-cross-arm/git+gitAUTOINC+c654a07d29-r0/build/x86_64-linux/rt/llvmdeps.rs LD_LIBRARY_PATH=/home/cody/obj/y/tmp/work/x86_64-poky-linux-gnueabi/rust-cross-arm/git+gitAUTOINC+c654a07d29-r0/build/x86_64-linux/stage2/lib/arm-poky-linux-gnueabi:$LD_LIBRARY_PATH   x86_64-linux/stage2/bin/arm-poky-linux-gnueabi/rustc --cfg stage2  -O --cfg rtopt --cfg ndebug -C rpath  --target=x86_64-linux   -C prefer-dynamic -D warnings -L "x86_64-linux/rt" -L "/home/cody/obj/y/tmp/work/x86_64-poky-linux-gnueabi/rust-cross-arm/git+gitAUTOINC+c654a07d29-r0/build/x86_64-linux/llvm/Release/lib"    --out-dir x86_64-linux/stage2/lib/arm-poky-linux-gnueabi/rustlib/x86_64-linux/lib -C extra-filename=-d8ace771 /home/cody/obj/y/tmp/work/x86_64-poky-linux-gnueabi/rust-cross-arm/git+gitAUTOINC+c654a07d29-r0/git/src/librustc_llvm/lib.rs
| error: could not exec the linker `arm-poky-linux-gnueabi-`: No such file or directory (os error 2)

Essentially, 'LINK_foo' is empty.

Heres a list:

# grep -L '^LINK_.*' -r cfg/mk
./x86_64-unknown-bitrig.mk
./powerpc-unknown-linux-gnu.mk
./i386-apple-ios.mk
./arm-unknown-linux-gnueabi.mk
./x86_64-unknown-freebsd.mk
./i686-pc-windows-gnu.mk
./mips-unknown-linux-gnu.mk
./armv7s-apple-ios.mk
./x86_64-unknown-dragonfly.mk
./arm-unknown-linux-gnueabihf.mk
./x86_64-unknown-openbsd.mk
./mipsel-unknown-linux-gnu.mk
./x86_64-unknown-linux-musl.mk
./x86_64-apple-ios.mk
./armv7-apple-ios.mk
@codyps
Copy link
Contributor Author

codyps commented May 26, 2015

@nyx I think this is your issue. (I ran into it myself while doing a build)

@codyps codyps changed the title Multiple targets broken due to lack of LINK_ entry in cfg/mk/*.mk Building rustc broken for multiple targets due to lack of LINK_ entry in cfg/mk/*.mk May 26, 2015
@codyps
Copy link
Contributor Author

codyps commented May 26, 2015

Dup of #25723 , apparently.

@alexcrichton
Copy link
Member

I believe this will be fixed by #25799

@alexcrichton alexcrichton mentioned this issue May 26, 2015
Merged
@codyps
Copy link
Contributor Author

codyps commented May 26, 2015

Closing as a duplicate.

@codyps codyps closed this as completed May 26, 2015
bors added a commit that referenced this issue May 27, 2015
@bors
Auto merge of #25799 - alexcrichton:fix-link-in-mk, r=luqmana
af60248 
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the `LINK_$(1)` variable for all
targets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).

Closes #25723
Closes #25802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mk: Ensure LINK_$(1) is defined for all targets alexcrichton/rust
2 participants
@alexcrichton @codyps