Skip to content

Source Code comments containing old array syntax #26074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheNeikos opened this issue Jun 7, 2015 · 4 comments
Closed

Source Code comments containing old array syntax #26074

TheNeikos opened this issue Jun 7, 2015 · 4 comments

Comments

@TheNeikos
Copy link
Contributor

Would a pull request fixing the source code comments be appreciated? I noticed that there were a few here and there in the source code.

I mean notations like [T, ..n] instead of [T; n] which was added in rfc#520

I ask because it is a minor change, and perhaps there is already a system in place for cleanup. (Which I did not find in Contributing.md)
@sanxiyn
Copy link
Member

sanxiyn commented Jun 8, 2015

Yes, I think it will be appreciated.

@steveklabnik
Copy link
Member

Agreed, I will r+ such a PR.

On Mon, Jun 8, 2015 at 11:18 AM, Seo Sanghyeon [email protected]
wrote:

Yes, I think it will be appreciated.

—
Reply to this email directly or view it on GitHub
#26074 (comment).

@steveklabnik
Copy link
Member

(But given that this is not a bug, I'm giving it a close)

@TheNeikos
Copy link
Contributor Author

I have submitted my pr: #26099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @sanxiyn @TheNeikos