Skip to content

Rust Book Grammatical Error #29401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddrouin opened this issue Oct 27, 2015 · 1 comment
Closed

Rust Book Grammatical Error #29401

ddrouin opened this issue Oct 27, 2015 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@ddrouin
Copy link

ddrouin commented Oct 27, 2015

In The Stack and Heap section:

"There’s some important things we have to take note of here."

is slightly incorrect because there's is usually considered as a contraction for there is. Although according to this: http://english.stackexchange.com/questions/12865/is-therere-similar-to-theres-a-correct-contraction maybe it's acceptable. Nonetheless it would be better to write:

"There are some important things we have to take note of here."

@steveklabnik steveklabnik added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Oct 27, 2015
@steveklabnik
Copy link
Member

Thank you! I would accept a patch for that change.

If anyone would like to try to fix this, I'm willing to help. The source is in src/doc/trpl/the-stack-and-the-heap.md, just the text needs changed.

pmarcelll added a commit to pmarcelll/rust that referenced this issue Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants