Skip to content

Links to types in an extern crate declared somewhere other than the crate root are broken #30109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfackler opened this issue Nov 30, 2015 · 1 comment
Closed

Links to types in an extern crate declared somewhere other than the crate root are broken #30109

sfackler opened this issue Nov 30, 2015 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

See for example SslStream on this page: http://sfackler.github.io/rust-postgres/doc/v0.10.1/postgres/io/trait.StreamWrapper.html

The link has an /io/openssl/ in it that shouldn't be there.
@sfackler sfackler added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 30, 2015
@mitaa
Copy link
Contributor

mitaa commented Nov 30, 2015

I'm pretty sure this broke with #27458, which invalidates the assumption that the local path is eqivalent to the extern path.

https://github.com/rust-lang/rust/blob/master/src/librustdoc/clean/inline.rs#L134-L147

@mitaa mitaa mentioned this issue Dec 1, 2015
Merged
bors added a commit that referenced this issue Dec 3, 2015
@bors
Auto merge of #30149 - mitaa:fqn, r=alexcrichton
c7d5832 
Fixes #30109
@mitaa mitaa mentioned this issue Feb 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfackler @mitaa