Skip to content

[MIR]-based translation of extension method calls does not actually work yet #30674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelwoerister opened this issue Jan 1, 2016 · 0 comments
Closed

[MIR]-based translation of extension method calls does not actually work yet #30674

michaelwoerister opened this issue Jan 1, 2016 · 0 comments
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html

Comments

@michaelwoerister
Copy link
Member

The extension method test in run-pass/mir_trans_calls.rs does not actually test the MIR translation path because the #[rustc_mir] attribute on the function is not picked up.
There is already PR #30661 that fixes the ignoring of attributes on generic functions. Once it has landed, the test method can be used in its current form. Otherwise it would have to be rewritten in a non-generic way.
@michaelwoerister michaelwoerister added the A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Jan 1, 2016
@michaelwoerister michaelwoerister mentioned this issue Jan 1, 2016
Merged
nagisa added a commit to nagisa/rust that referenced this issue Jan 6, 2016
@nagisa
Reenable MIR test
9039085 
Fixes rust-lang#30674
@nagisa nagisa mentioned this issue Jan 6, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Jan 8, 2016
@steveklabnik
Rollup merge of rust-lang#30747 - nagisa:mir-reenable-test, r=nikomat…
27df1ec 
…sakis

Fixes rust-lang#30674

The test seems to work fine and assertion passes. The test seems to also be generated from MIR (LLVM IR has footprint of MIR translator), thus I’m reenabling it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelwoerister