Skip to content

"let () =" should be irrefutable #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Aug 4, 2012 · 0 comments
Closed

"let () =" should be irrefutable #3104

bblum opened this issue Aug 4, 2012 · 0 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.5

Comments

@bblum
Copy link
Contributor

bblum commented Aug 4, 2012 

fn main() {
    let () = ();
}

fails with

unit.rs:2:8: 2:10 error: refutable pattern in local binding
unit.rs:2     let () = ();
                  ^~
@bblum bblum closed this as completed in 9b489f6 Aug 22, 2012
@ghost ghost assigned bblum Aug 22, 2012
@bblum bblum removed their assignment Jun 16, 2014
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@otavio
Cargo.lock: update cargo_metadata to 0.6.1 release
38e7f24 
The update is especially important as it adds support for the
`edition` field handling, when parsing `cargo` metadata.

Refs: rust-lang#3104.

Signed-off-by: Otavio Salvador <[email protected]>
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@otavio
rustfmt: add support to specify the Rust edition as argument
e41fcb1 
The new `--edition` command line argument allow the setting of the
desired Rust edition to be used.

Refs: rust-lang#3104.

Signed-off-by: Otavio Salvador <[email protected]>
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@otavio
cargo-fmt: Take into account the edition for each target
de0b661 
When formatting the crate, with `cargo fmt`, it parses each target
with the specific Rust edition.

Fixes: rust-lang#3104.

Signed-off-by: Otavio Salvador <[email protected]>
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@otavio
README: remove old requirement for Rust 2018 edition use
b189350 
From now on, the `Cargo.toml` is taken into account when triggering
formatting using `cargo fmt`.

It is considered editor's duty to pass the proper `--edition` argument
for `rustfmt` if it is being called manually.

Refs: rust-lang#3104.
Refs: rust-lang#3129.

Signed-off-by: Otavio Salvador <[email protected]>
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@otavio
Stabilize edition configuration option
9c3ae2d 
Refs: rust-lang#3104.

Signed-off-by: Otavio Salvador <[email protected]>
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@dependabot
Bump tests/perf/s2n-quic from 1a7faa8 to 0a60ec1 (rust-lang#3104)
9de7201 
Bumps [tests/perf/s2n-quic](https://github.com/aws/s2n-quic) from
`1a7faa8` to `0a60ec1`.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aws/s2n-quic/commit/0a60ec19ea9a8cd1bef98ad9798327521d2121ee"><code>0a60ec1</code></a>
test: generate script for testing certs and keys (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2161">#2161</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/15f234c495f98cf61652cf70e8dbc3c7565098b4"><code>15f234c</code></a>
feat(s2n-quic-rustls): update rustls from 0.21 to 0.23 (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2143">#2143</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/aebd430b4eee5b5cbaff2677f4e65511719ac295"><code>aebd430</code></a>
ci: update rust nightly version (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2159">#2159</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/26874c29c18f91ff6bc61b1b330182892a893a21"><code>26874c2</code></a>
build: fix clippy warnings for 1.77 (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2158">#2158</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/d9c6bd6ea71279034963fc882c5951f9eb2d2789"><code>d9c6bd6</code></a>
ci: add musl tests (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2102">#2102</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/ac7bf906d1c883e22fd3ada80e42fe16db95b7da"><code>ac7bf90</code></a>
fix(s2n-quic-platform): don't reduce rx MTU when tx MTU is reduced (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2156">#2156</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/9e39ca0f4aa00ffacc9d65879ccc807460c8b04b"><code>9e39ca0</code></a>
build(deps): update heck requirement from 0.4 to 0.5 (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2152">#2152</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/2d4df73eddf3ea26ade90eae9e766b7f2c08a86b"><code>2d4df73</code></a>
feat(s2n-quic-xdp): add umem hugepage option (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2145">#2145</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/440f4f45629bc99b1a815a6d42c01c39af382e72"><code>440f4f4</code></a>
build(deps): bump docker/setup-buildx-action from 3.1.0 to 3.2.0 (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2153">#2153</a>)</li>
<li><a
href="https://github.com/aws/s2n-quic/commit/d73c6484fc16be988741fd7c5f26c59a9960896c"><code>d73c648</code></a>
build(deps): bump docker/login-action from 3.0.0 to 3.1.0 (<a
href="https://redirect.github.com/aws/s2n-quic/issues/2154">#2154</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/aws/s2n-quic/compare/1a7faa87ebcf2b84a068f21af3306a6f42eb8c74...0a60ec19ea9a8cd1bef98ad9798327521d2121ee">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@bblum