Skip to content

Move enum_variant_size_lint out of trans_crate(). #34018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaelwoerister opened this issue Jun 1, 2016 · 1 comment · Fixed by #34755
Closed

Move enum_variant_size_lint out of trans_crate(). #34018

michaelwoerister opened this issue Jun 1, 2016 · 1 comment · Fixed by #34755
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

The enum_variant_size_lint is located in trans because we formerly relied on LLVM for providing type layouts. This is not true any more and after collector-driven trans lands, enum_variant_size_lint is the only reason we walk the HIR in trans_crate() at all. This should be cleaned up.
@michaelwoerister michaelwoerister added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-compiler labels Jun 1, 2016
@michaelwoerister michaelwoerister mentioned this issue Jun 1, 2016
Merged
@jonas-schievink
Copy link
Contributor

Collector-driven trans is now merged, so I'm rebasing my patch for this.

@jonas-schievink jonas-schievink mentioned this issue Jul 10, 2016
Merged
bors added a commit that referenced this issue Jul 12, 2016
@bors
Auto merge of #34755 - jonas-schievink:minor-differences, r=eddyb
5c69a4f 
Move variant_size_differences out of trans

Also enhances the error message a bit, fixes #30505 on the way, and adds
a test (which was missing).

Closes #34018
@steveklabnik steveklabnik added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move variant_size_differences out of trans
3 participants
@steveklabnik @jonas-schievink @michaelwoerister