-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Regression in Beta and Nightly in type inference #36352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
That's because of the |
This was also reported 5 times on crater late in the beta cycle: #36352 |
I'm opening this to consider reverting. |
bors
added a commit
that referenced
this issue
Sep 24, 2016
Revert "implement `From<Vec<char>>` and `From<&'a [char]>` for `String`" This reverts commit ac73335. This is a revert of #35054, which resulted in at least 7 known regressions, reported [here](https://internals.rust-lang.org/t/regression-report-stable-2016-08-16-vs-beta-2016-09-21/4119) and [here](#36352), which will hit stable next week. I think this breakage was somewhat unanticipated, and we did not realize so many crates were broken until this week, so reverting is the conservative thing to do until we figure out how not to cause so much breakage. I've run crater on the revert and did not find any new breakage from the revert. Fixes #36352 cc @pwoolcoc @rust-lang/libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Stable build: https://travis-ci.org/SUPERAndroidAnalyzer/super/jobs/158500096
Beta build: https://travis-ci.org/SUPERAndroidAnalyzer/super/jobs/158500095
Nightly build: https://travis-ci.org/SUPERAndroidAnalyzer/super/jobs/158500094
Beta and nightly fail when trying to get a file name as a
String
from aPathBuf
. The code is the following:And it also happens when getting the value from an
AsRef<str>
, in this example code:In both cases the error is the same:
type annotations required: cannot resolve std::string::String: std::convert::From<&_>
The text was updated successfully, but these errors were encountered: