Skip to content

Switch the order of pipes::stream's result #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Oct 2, 2012 · 5 comments
Closed

Switch the order of pipes::stream's result #3637

brson opened this issue Oct 2, 2012 · 5 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone

Comments

@brson
Copy link
Contributor

brson commented Oct 2, 2012

stream returns (Chan, Port) but I intuitively expect (Port, Chan) (not sure why). I've seen others make this mistake too.

@nikomatsakis
Copy link
Contributor

+1. Somehow "port and channel" sounds right, "channel and port" sounds
backwards.

@ben0x539
Copy link
Contributor

ben0x539 commented Oct 4, 2012

The pipe syscall gives you the read end of the pipe first and the write end second, maybe that's why?

@BrendanEich
Copy link

@ben0x539 that's a good reason that Unix nerds like me find compelling, but I think @nikomatsakis is pointing to the poetic win of trochaic PORT and CHANnel vs. the awkwardly inverted foot in CHANnel and PORT.

/be

@catamorphism
Copy link
Contributor

Done pending review (not that anything needs reviewing, but I wanted to make sure there was really consensus).

@catamorphism
Copy link
Contributor

Done: 38bd694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

5 participants