Skip to content

[Regression] test fails on 1.14.0-beta.2 (e627a2e6e 2016-11-16) with 'attempt to add with overflow' #37959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zetok opened this issue Nov 23, 2016 · 2 comments

Comments

@zetok
Copy link

zetok commented Nov 23, 2016

Regressed from current and past stable (works on 1.13.0, 1.12.1) to current beta (1.14.0).

Error:

'attempt to add with overflow', ../src/libcore/ops.rs:263

Probably the code that beta handles wrongly: zetok/tox@0885d7e#diff-47bd9ee511e98206d1a2d1ad0809b219R1427

Works on stable rustc 1.13.0 (2c6933a 2016-11-07): https://travis-ci.org/zetok/tox/jobs/177605738#L960
Failed on beta rustc 1.14.0-beta.2 (e627a2e 2016-11-16): https://travis-ci.org/zetok/tox/jobs/177605739#L1137

@bluss
Copy link
Member

bluss commented Nov 23, 2016

This is intentional and it also was a regression that it stopped panicking (in 1.12 ?). It was fixed to not silently overflow in #36365

zetok added a commit to zetok/tox that referenced this issue Nov 23, 2016
Apparently code depended on regression in the stable rustc to work.
Newest beta rustc (1.14) fixes the regression, so the code would no
longer work.

rust-lang/rust#37959
@arielb1
Copy link
Contributor

arielb1 commented Nov 23, 2016

Sure enough. Not a bug, but a fix to a regression introduced by MIR.

@arielb1 arielb1 closed this as completed Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants