dead_code doesn't show unused struct as unused

[KalitaAlexey]

Hi everybody.

I am sorry I tried to minify the example, but I can't find a pattern.
There is a PR: rust-lang/rls#168
There is an commit: "Replaced uses of unwrap with expect.".
In the commit in the src/actions/build.mod file there are two structs: CompilerMessageCode, CompilerMessage which are unused.
The compiler doesn't show any warning.

[durka]

They were marked pub.

[KalitaAlexey]

@durka,
They were in a function.
Can I use pub outside of the function?

[durka]

To be honest, I would have expected some other error saying that pub doesn't make any sense inside a function :) As far as I know, the lint ignored them for that reason though.

[KalitaAlexey]

@durka,
It compiled and worked.

[petrochenkov]

@durka

To be honest, I would have expected some other error saying that pub doesn't make any sense inside a function

It was an error a year ago (see #31776)

[durka]

This case would ideally be caught by the possibly-upcoming "this item is not as public as it looks" lint.

[steveklabnik]

So it appears this is not a bug. Closing! (Let me know if I've gotten this wrong)