Skip to content

Bad span for attributes #42641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nrc opened this issue Jun 13, 2017 · 0 comments
Closed

Bad span for attributes #42641

nrc opened this issue Jun 13, 2017 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@nrc
Copy link
Member

nrc commented Jun 13, 2017

The span for ast::MetaItem and ast::NestedMetaItem is not quite correct (looks like it contains an opening ( but not the closing ))

cc rust-lang/rustfmt#1668
@nrc nrc added the A-diagnostics Area: Messages for errors, warnings, and lints label Jun 13, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 26, 2017
@topecongiro topecongiro mentioned this issue Aug 17, 2017
Merged
bors added a commit that referenced this issue Aug 19, 2017
@bors
Auto merge of #43933 - topecongiro:bad-span-for-attributes, r=petroch…
c7e3c79 
…enkov

Fix bad span for attributes

Closes #42641.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrc @Mark-Simulacrum