Skip to content

flatpipes::util::BufReader::as_bytes_reader doesn't handle failure #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jan 10, 2013 · 3 comments
Closed

flatpipes::util::BufReader::as_bytes_reader doesn't handle failure #4429

catamorphism opened this issue Jan 10, 2013 · 3 comments

Comments

@catamorphism
Copy link
Contributor

XXX (now a FIXME) says: "This isn't correct if f fails". In code I'm about to commit, I'm moving this from flatpipes::util into std::io_util
@metajack
Copy link
Contributor

This is still an issue.

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Still relevant

@pnkfelix
Copy link
Member

pnkfelix commented Feb 6, 2014

this is gone. closing.

@pnkfelix pnkfelix closed this as completed Feb 6, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue May 27, 2020
@bors
Auto merge of rust-lang#4429 - jeremystucki:or_fun_call, r=flip1995
dd06d29 
Update 'or_fun_call' to ignore calls to len

Resolves rust-lang#1653

changelog: Update `or_fun_call`: Allow calls to `len` for Slice, Array & Vec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@metajack @pnkfelix @catamorphism @emberian