Skip to content

rustbuild: don't fetch jemalloc if it's disabled #45300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ishitatsuyuki opened this issue Oct 15, 2017 · 0 comments
Closed

rustbuild: don't fetch jemalloc if it's disabled #45300

ishitatsuyuki opened this issue Oct 15, 2017 · 0 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@ishitatsuyuki
Copy link
Contributor

Currently jemalloc is skipped if system library is specified. We should also do so when use_jemalloc is False.
@kennytm kennytm added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 15, 2017
@Mark-Simulacrum Mark-Simulacrum added C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority WG-infra-rustbuild labels Oct 15, 2017
ishitatsuyuki added a commit to ishitatsuyuki/rust that referenced this issue Oct 17, 2017
@ishitatsuyuki
bootstrap: Avoid fetching jemalloc if it's disabled
cbe4116 
Fix rust-lang#45300
@ishitatsuyuki ishitatsuyuki mentioned this issue Oct 17, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this issue Oct 17, 2017
@kennytm
Rollup merge of rust-lang#45338 - ishitatsuyuki:boot-jemalloc, r=aidanhs
e72c2a8 
bootstrap: Avoid fetching jemalloc if it's disabled

Fix rust-lang#45300

More conditions, more madness :) Tested locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-low Low priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kennytm @Mark-Simulacrum @ishitatsuyuki