Skip to content

[rustdoc] Improve "Types/modules" label on the search results page #45787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Seeker14491 opened this issue Nov 5, 2017 · 4 comments
Closed

[rustdoc] Improve "Types/modules" label on the search results page #45787

Seeker14491 opened this issue Nov 5, 2017 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Seeker14491
Copy link
Contributor

The first tab on the search results page is labeled "Types/modules", but the search results include items which are neither, such as functions and macros:

results for file

I suggest changing the label to something like "In name".
@Seeker14491 Seeker14491 mentioned this issue Nov 5, 2017
Closed
@kennytm kennytm added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 5, 2017
@JRegimbal
Copy link
Contributor

Maybe "As name" would be better to just match the other tabs?

@Seeker14491
Copy link
Contributor Author

The "As parameters" and "As return value" tabs only return results that match the whole search text exactly, while the first tab also returns items that partially match the search text. Because of this distinction, I prefer "in" over "as".

@JRegimbal
Copy link
Contributor

Ah my bad I didn't understand the difference between the name search and the parameter/return value searches.

@JRegimbal JRegimbal mentioned this issue Nov 9, 2017
Merged
@steveklabnik steveklabnik added T-dev-tools-rustdoc and removed A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 21, 2017
bors added a commit that referenced this issue Dec 6, 2017
@bors
Auto merge of #45898 - JRegimbal:master, r=QuietMisdreavus
d10b04d 
Change "Types/modules" title of search tab to be more accurate

From issue #45787. Used "In name" as per suggestion from @Seeker14491.
@QuietMisdreavus
Copy link
Member

Fixed in #45898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @kennytm @QuietMisdreavus @Seeker14491 @JRegimbal